Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
lkdvos
approved these changes
Mar 22, 2026
Merged
lkdvos
referenced
this pull request
Mar 25, 2026
….4, (keep existing compat) (#201) * CompatHelper: bump compat for GenericLinearAlgebra in [weakdeps] to 0.4, (keep existing compat) * Remove JET dependency Removed JET dependency from Project.toml * Remove JET from test targets Removed JET from the test targets in Project.toml. --------- Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: Lukas Devos <ldevos98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some suggestions for some more updates on top of all the magnificent work of the algorithm redesign by @lkdvos . I've changed the naming convention to be
methodname_algorithmnameconsistently, for the lapack-style algorithms as well as some of the others (native, polar_newton, …). I've also moved the LAPACK specific manipulations (such as generating an empty matrix when no vectors are required) to the body of these functions.